added newline after function signature, before opening brace #7399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badasahog
requested review from
HughParsonage,
MichaelChirico,
aitap,
ben-schwen,
jangorecki and
tdhock
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7399 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 85 85
Lines 16610 16610
=======================================
Hits 16466 16466
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So far, the conclusion from the discussion on this issue is not to proceed with the change. The change would affect the history of 34 files, and it doesn’t seem necessary. It would be nice if the style were consistent, but it isn’t, and as long as it is not less readable, then I don't think there is anything to solve here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was actually about a 50/50 split, so this should make code more consistent.
closes #7395